Add initial e2e tests. Implement page objects for admin and experiment page #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npaton
reviewed
Nov 25, 2022
npaton
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Overall looks good. I think the API to address the pages is pretty nice. This PR looks good to go to me.
Generally, I think the API you built around the pages is quite functional and readable. Though, some classes feel like they don't have much work or reason to exist. That being said, as you add more tests, some of these will become beefier (while some won't, like the "Finished" page).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.